Skip to content

Conversation

@qaisjp
Copy link
Member

@qaisjp qaisjp commented Jan 11, 2026

Summary

  • Make clang-format.ps1 executable
  • Run ./utils/clang-format.ps1 to format all files
  • Use fastmod '} // namespace [a-zA-Z0-9]+$' '}' Client/ Server/ Shared/ to remove comments left over from FixNamespaceComments: true
  • Add codemod to .git-blame-ignore-revs

Motivation

Make master green after #4626

Test plan

Changes were generated entirely by automated scripts

@qaisjp qaisjp requested a review from a team as a code owner January 11, 2026 03:09
@qaisjp qaisjp changed the title Run ./utils/clang-format.ps1 [Ready to review, but don't merge yet] Run ./utils/clang-format.ps1 Jan 11, 2026
@qaisjp qaisjp requested review from botder and sbx320 January 14, 2026 06:28
* disable FixNamespaceComments
* set InsertNewlineAtEOF
* set SpacesBeforeTrailingComments: 2

Make the script executable
@qaisjp qaisjp changed the title [Ready to review, but don't merge yet] Run ./utils/clang-format.ps1 Run ./utils/clang-format.ps1 Jan 17, 2026
@qaisjp qaisjp removed request for botder and sbx320 January 17, 2026 15:22
@qaisjp qaisjp merged commit ab74393 into master Jan 17, 2026
15 checks passed
@qaisjp qaisjp deleted the clang-format branch January 17, 2026 15:32
@qaisjp
Copy link
Member Author

qaisjp commented Jan 17, 2026

reverted in a665e01

1.6 branch has diverged. annoying to fix conflicts. we'll re-merge this when 1.7 lands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants